Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default username when pushing container images to Quay.io #2809

Merged
merged 1 commit into from
Feb 11, 2021
Merged

Fix default username when pushing container images to Quay.io #2809

merged 1 commit into from
Feb 11, 2021

Conversation

jpkrohling
Copy link
Contributor

The PR #2783 introduced a change where container images are also pushed to Quay, but unfortunately, the username was incorrectly set. In order to use the same account that the jaeger-operator uses, I'm changing this here instead of creating a new robot account.

Signed-off-by: Juraci Paixão Kröhling [email protected]

@jpkrohling jpkrohling requested a review from a team as a code owner February 11, 2021 11:08
@jpkrohling jpkrohling requested a review from vprithvi February 11, 2021 11:08
@codecov
Copy link

codecov bot commented Feb 11, 2021

Codecov Report

Merging #2809 (16fc5dc) into master (3d9537d) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2809      +/-   ##
==========================================
- Coverage   95.94%   95.93%   -0.02%     
==========================================
  Files         218      218              
  Lines        9620     9620              
==========================================
- Hits         9230     9229       -1     
- Misses        322      323       +1     
  Partials       68       68              
Impacted Files Coverage Δ
cmd/query/app/static_handler.go 95.16% <0.00%> (-1.62%) ⬇️
plugin/storage/integration/integration.go 77.34% <0.00%> (-0.56%) ⬇️
cmd/query/app/server.go 97.08% <0.00%> (+1.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3d9537d...dc0da9e. Read the comment docs.

@Ashmita152
Copy link
Contributor

+1 from my side. Thank you for fixing it 🙏

@yurishkuro yurishkuro merged commit c8b8168 into jaegertracing:master Feb 11, 2021
@jpkrohling jpkrohling deleted the jpkrohling/fix-quay-username branch July 28, 2021 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants