Enable stale bot for PRs and questions #2731
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurishkuro
requested review from
pavolloffay and
jpkrohling
and removed request for
pavolloffay
Codecov Report
@@ Coverage Diff @@
## master #2731 +/- ##
=======================================
Coverage 95.82% 95.82%
=======================================
Files 217 217
Lines 9650 9650
=======================================
Hits 9247 9247
- Misses 331 332 +1
+ Partials 72 71 -1
Continue to review full report at Codecov.
|
jpkrohling
reviewed
Jan 19, 2021
.github/stale.yml
Outdated
| markComment: > | ||
| This pull request has been automatically marked as stale because it has not had | ||
| recent activity. It will be closed if no further activity occurs. You may re-open | ||
| it if you need more time. Thank you for your contributions. |
There was a problem hiding this comment.
Thank you for your contributions. sounds ironic here. I would either remove, or make it "warmer":
Suggested change
| it if you need more time. Thank you for your contributions. | |
| it if you need more time. We really appreciate your contribution and we are sorry that this hasn't been completed. |
There was a problem hiding this comment.
sgtm, but I would move this to the Close comment instead.
.github/stale.yml
Outdated
| it if you need more time. Thank you for your contributions. | ||
| closeComment: > | ||
| This pull request has been automatically closed due to inactivity. You may re-open | ||
| it if you need more time. Thank you for your contributions. |
There was a problem hiding this comment.
Suggested change
| it if you need more time. Thank you for your contributions. | |
| it if you need more time. |
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
jpkrohling
previously approved these changes
Jan 20, 2021
mergify
bot
dismissed
jpkrohling’s stale review
Pull request has been modified.
bhiravabhatla
pushed a commit
to bhiravabhatla/jaeger
that referenced
this pull request
Jan 25, 2021
* Enable stale bot for PRs and questions Signed-off-by: Yuri Shkuro <[email protected]> * make it "warmer" Signed-off-by: Yuri Shkuro <[email protected]> * change stale label Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Juraci Paixão Kröhling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2717
@jpkrohling PTAL