-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend anonymizer with additional parameters #2585
Conversation
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consider adding unit tests
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Thank you for the feedbacks earlier. I have updated the PR with the feedbacks. It's ready for review again. |
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Hi @yurishkuro Thank you for the feedbacks earlier. I have updated the PR based on your feedback. |
Signed-off-by: Ashmita Bohara <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #2585 +/- ##
==========================================
- Coverage 95.31% 95.02% -0.29%
==========================================
Files 208 209 +1
Lines 9285 9369 +84
==========================================
+ Hits 8850 8903 +53
- Misses 356 388 +32
+ Partials 79 78 -1
Continue to review full report at Codecov.
|
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Signed-off-by: Ashmita Bohara <[email protected]>
Hi @yurishkuro This PR is ready for review again. Thank you for your constant help. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Signed-off-by: Ashmita Bohara [email protected]
Which problem is this PR solving?
Partially fixes #2556
Short description of the changes
Extends the Anonymizer type with these additional parameters