Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor] Clean-up tests from #2188 #2200

Merged
merged 1 commit into from
Apr 25, 2020

Conversation

yurishkuro
Copy link
Member

Address remaining comments from #2188

@yurishkuro yurishkuro requested a review from a team as a code owner April 25, 2020 23:06
@yurishkuro yurishkuro requested a review from pavolloffay April 25, 2020 23:06
@codecov
Copy link

codecov bot commented Apr 25, 2020

Codecov Report

Merging #2200 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2200   +/-   ##
=======================================
  Coverage   96.17%   96.18%           
=======================================
  Files         219      219           
  Lines       10628    10632    +4     
=======================================
+ Hits        10222    10226    +4     
  Misses        351      351           
  Partials       55       55           
Impacted Files Coverage Δ
...in/sampling/strategystore/static/strategy_store.go 100.00% <100.00%> (ø)
cmd/query/app/server.go 91.78% <0.00%> (-2.74%) ⬇️
cmd/query/app/static_handler.go 88.59% <0.00%> (+1.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b687b1b...662f41a. Read the comment docs.

@yurishkuro yurishkuro merged commit 66993a2 into jaegertracing:master Apr 25, 2020
@yurishkuro yurishkuro deleted the cleanup-2188 branch April 25, 2020 23:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant