Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add C* query to error logs #1250

Merged
merged 2 commits into from
Jan 1, 2019
Merged

Add C* query to error logs #1250

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
cba3c9c
Add query to read error log
vprithvi Dec 13, 2018
f77566d
Merge branch 'master' into log-failing-queries
yurishkuro Jan 1, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion plugin/storage/cassandra/spanstore/reader.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -410,7 +410,8 @@ func (s *SpanReader) executeQuery(span opentracing.Span, query cassandra.Query,
tableMetrics.Emit(err, time.Since(start))
if err != nil {
logErrorToSpan(span, err)
s.logger.Error("Failed to exec query", zap.Error(err))
span.LogFields(otlog.String("query", query.String()))
s.logger.Error("Failed to exec query", zap.Error(err), zap.String("query", query.String()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

zap.String("query", query.String()) => zap.Stringer("query", query)

return nil, err
}
return retMe, nil
Expand Down
1 change: 1 addition & 0 deletions plugin/storage/cassandra/spanstore/reader_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -305,6 +305,7 @@ func TestSpanReaderFindTraces(t *testing.T) {
query.On("Consistency", cassandra.One).Return(query)
query.On("PageSize", 0).Return(query)
query.On("Iter").Return(iter)
query.On("String").Return("queryString")

return query
}
Expand Down