Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close gRPC for collecting and reporting #1187

Merged
merged 1 commit into from
Nov 16, 2018

Conversation

pavolloffay
Copy link
Member

Resolves #1164
and part of #773 (comment)

Signed-off-by: Pavol Loffay [email protected]

@codecov
Copy link

codecov bot commented Nov 15, 2018

Codecov Report

Merging #1187 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1187   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         157     157           
  Lines        7101    7107    +6     
======================================
+ Hits         7101    7107    +6
Impacted Files Coverage Δ
cmd/agent/app/reporter/tchannel/collector_proxy.go 100% <100%> (ø) ⬆️
cmd/agent/app/reporter/grpc/collector_proxy.go 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76ccd71...d28c2ff. Read the comment docs.

@yurishkuro yurishkuro merged commit 78d32fc into jaegertracing:master Nov 16, 2018
@ghost ghost removed the review label Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants