Add a 'save failed by service' metric, as currently a counter is only… #1064
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
objectiser
requested review from
black-adder,
jpkrohling,
pavolloffay,
vprithvi and
yurishkuro
as code owners
ghost
assigned 
|
"save-failed-by-svc" is just a placeholder - happy to change to a better name. |
black-adder
reviewed
Sep 18, 2018
cmd/collector/app/metrics.go
Outdated
| BatchSize: hostMetrics.Gauge("batch-size", nil), | ||
| QueueLength: hostMetrics.Gauge("queue-length", nil), | ||
| ErrorBusy: hostMetrics.Counter("error.busy", nil), | ||
| SavedBySvc: newMetricsBySvc(serviceMetrics, "saved-by-svc"), |
There was a problem hiding this comment.
I'd prefer if we used tags instead: metric name = saved-by-svc, tag = success|fail
There was a problem hiding this comment.
although, technically it'll be a breaking change but we've gone ahead with metric changes without considering it a breaking change
There was a problem hiding this comment.
If we want to take this approach, then there are some other places that should be changed also - e.g. jaeger_find_traces_errLatency_count and jaeger_find_traces_okLatency_count. But I agree it would be better to have it as a tag on the metric.
… used to keep track of successful span saves Signed-off-by: Gary Brown <[email protected]>
Signed-off-by: Gary Brown <[email protected]>
objectiser
force-pushed
the
writefailed
branch
from
6267bde to
a8b3f2d
Compare
black-adder
approved these changes
Sep 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… used to keep track of successful span saves
Signed-off-by: Gary Brown [email protected]
Which problem is this PR solving?
Currently a counter is only available to record successfully saved spans. An error is reported if the write fails, but no counter is provided.
Short description of the changes
Add a counter to record the number of span write failures.