Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use reliable bad address to guarantee failure #1003

Merged
merged 2 commits into from
Aug 17, 2018
Merged

Use reliable bad address to guarantee failure #1003

merged 2 commits into from
Aug 17, 2018

Conversation

isaachier
Copy link
Contributor

@isaachier isaachier commented Aug 17, 2018 •
edited
Loading

@isaachier
Copy link
Contributor Author

Kafka integration test is breaking build here. @davit-y @vprithvi any ideas?

@codecov
Copy link

codecov bot commented Aug 17, 2018 •
edited
Loading

Codecov Report

Merging #1003 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1003   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files         139     139           
  Lines        6399    6399           
======================================
  Hits         6399    6399

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7491647...7f72578. Read the comment docs.

@vprithvi
Copy link
Contributor

@isaachier none yet, created #1004 to track this.

@black-adder black-adder merged commit ab95771 into jaegertracing:master Aug 17, 2018
@isaachier isaachier deleted the bad-address-fix branch August 17, 2018 17:02
isaachier added a commit to isaachier/jaeger that referenced this pull request Sep 3, 2018
@isaachier
Use reliable bad address to guarantee test failure (jaegertracing#1003)
1a00f27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@black-adder black-adder black-adder approved these changes

@jpkrohling jpkrohling Awaiting requested review from jpkrohling

@pavolloffay pavolloffay Awaiting requested review from pavolloffay

@vprithvi vprithvi Awaiting requested review from vprithvi

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@isaachier @vprithvi @black-adder