[Bug]: Consumer offset manager metrics should have a tag with topic name #4950
Labels
Comments
|
I will fix it. |
abliqo
added a commit
to abliqo/jaeger
that referenced
this issue
Nov 14, 2023
…th topic name Resolves jaegertracing#4950 Add tag with topic name to metrics emitted by Kafka consumer offset manager. Signed-off-by: Alex Bublichenko <[email protected]>
yurishkuro
pushed a commit
that referenced
this issue
Nov 14, 2023
…4951) ## Which problem is this PR solving? Resolves #4950 ## Description of the changes Add tag with topic name to metrics emitted by Kafka consumer offset manager. ## How was this change tested? Unit tests Signed-off-by: Alex Bublichenko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What happened?
The recent change #4593 updated the consumer code of the ingester to support ingestion from multiple Kafka topics when sarama consumer is created in custom way with multiple topics. However, the metrics in the offset manager lack the tag with topic name.
Steps to reproduce
last-committed-offset- it does not have topic tag.Expected behavior
All consumer offset manager metrics should have a tag with topic name.
Relevant log output
No response
Screenshot
No response
Additional context
No response
Jaeger backend version
No response
SDK
No response
Pipeline
No response
Stogage backend
No response
Operating system
No response
Deployment model
No response
Deployment configs
No response
The text was updated successfully, but these errors were encountered: