[ci-release] SBOM not uploaded #4817
Comments
yurishkuro
added a commit
that referenced
this issue
Oct 7, 2023
## Which problem is this PR solving? - Resolves #4814 - Resolves #4817 ## Description of the changes - Set BRANCH=s/main/main_from_fork/ when running on pull requests. This should solve the problem with CI failing when people submit a PR from a main branch in their fork, because our CI scripts think it means docker images should be uploaded and fail on the lack of credentials. Now they will skip the uploads. - Move cleanup of android toolchain to the top of the workflow - Replace the use of `.github/actions/setup-branch` with custom logic to set BRANCH which is always based on the recent semver tag. `setup-branch` will still work for non-release workflows. - Remove unnecessary success checks in the steps (job fails when any step fails) - Use `env.BRANCH` as release name in `upload-release-action` action, instead of `github.ref` - Manually upload SBOM to the correct release (to solve #4817) ## How was this change tested? - Will have to run ci-release manually after merge --------- Signed-off-by: Yuri Shkuro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After successfully running the release workflow manually, I noticed that SBOM artifact is missing from the release asset. The log from
anchore/sbom-actionshowsbut I think this is just the workflow artifact, not a release artifact. The action's documentation mentions it can upload release artifact, but only when running on a release event.
The text was updated successfully, but these errors were encountered: