-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove dependency on jaeger-lib #3766
Comments
This was referenced Jun 21, 2022
yurishkuro
added a commit
that referenced
this issue
Jan 29, 2023
Based on earlier PR #3390 by @rbroggi. ## Which problem is this PR solving? - Resolves #3380 ## Short description of the changes - Switch from jaeger-client-go SDK to OTel SDK paired with ot-otel bridge - Add cli flag to select which Otel Exporter to use (Jaeger, OTLP or stdout) - Add favicon 🚗 - Added OTEL version of rpcmetrics from jaeger-client-go - Remove dependency on github.com/uber/jaeger-lib in HotROD (addresses one of outstanding tasks in #3766) --------- Signed-off-by: rbroggi <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: rbroggi <[email protected]>
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this issue
Feb 22, 2023
Based on earlier PR jaegertracing#3390 by @rbroggi. ## Which problem is this PR solving? - Resolves jaegertracing#3380 ## Short description of the changes - Switch from jaeger-client-go SDK to OTel SDK paired with ot-otel bridge - Add cli flag to select which Otel Exporter to use (Jaeger, OTLP or stdout) - Add favicon 🚗 - Added OTEL version of rpcmetrics from jaeger-client-go - Remove dependency on github.com/uber/jaeger-lib in HotROD (addresses one of outstanding tasks in jaegertracing#3766) --------- Signed-off-by: rbroggi <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: rbroggi <[email protected]>
shubbham1215
pushed a commit
to shubbham1215/jaeger
that referenced
this issue
Mar 5, 2023
Based on earlier PR jaegertracing#3390 by @rbroggi. ## Which problem is this PR solving? - Resolves jaegertracing#3380 ## Short description of the changes - Switch from jaeger-client-go SDK to OTel SDK paired with ot-otel bridge - Add cli flag to select which Otel Exporter to use (Jaeger, OTLP or stdout) - Add favicon 🚗 - Added OTEL version of rpcmetrics from jaeger-client-go - Remove dependency on github.com/uber/jaeger-lib in HotROD (addresses one of outstanding tasks in jaegertracing#3766) --------- Signed-off-by: rbroggi <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: rbroggi <[email protected]> Signed-off-by: shubbham1215 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There are several issues with the dependency on jaeger-lib:
go mod
is non-trivial because it's already v2There are two directions we can take:
internal
.* unfortunately, this does not fully remove dependency on jaeger-lib because we're still using jaeger-client-go (cf. Upgrade internal use of tracing to OpenTelemetry #3381, Upgrade HotROD example to use OpenTelemetry SDK #3380)
(Update 2023-01-29) Current plan:
The text was updated successfully, but these errors were encountered: