Skip to content

Commit

Permalink
Make OTLP receiver enabled by default (#4494)
Browse files Browse the repository at this point in the history
This simplifies compatibility with OTEL/OTLP by not requiring to set the
option to enable OTLP receiver. The option is still supported and allows
OTLP receiver to be disabled when needed.

---------

Signed-off-by: Yuri Shkuro <[email protected]>
  • Loading branch information
yurishkuro authored Jun 1, 2023
1 parent 756bc4e commit e2e257c
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 1 deletion.
15 changes: 15 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,21 @@ next release
### UI Changes


1.46.0
-------------------
### Backend Changes

#### ⛔ Breaking Changes

* Make OTLP receiver enabled by default ([@yurishkuro](https://github.com/yurishkuro) in [#4494](https://github.com/jaegertracing/jaeger/pull/4494))

#### New Features

#### Bug fixes, Minor Improvements

### UI Changes


1.45.0 (2023-05-03)
-------------------
### Backend Changes
Expand Down
2 changes: 1 addition & 1 deletion cmd/collector/app/flags/flags.go
Original file line number Diff line number Diff line change
Expand Up @@ -184,7 +184,7 @@ func AddFlags(flags *flag.FlagSet) {
addHTTPFlags(flags, httpServerFlagsCfg, ports.PortToHostPort(ports.CollectorHTTP))
addGRPCFlags(flags, grpcServerFlagsCfg, ports.PortToHostPort(ports.CollectorGRPC))

flags.Bool(flagCollectorOTLPEnabled, false, "Enables OpenTelemetry OTLP receiver on dedicated HTTP and gRPC ports")
flags.Bool(flagCollectorOTLPEnabled, true, "Enables OpenTelemetry OTLP receiver on dedicated HTTP and gRPC ports")
addHTTPFlags(flags, otlpServerFlagsCfg.HTTP, "")
addGRPCFlags(flags, otlpServerFlagsCfg.GRPC, "")

Expand Down

0 comments on commit e2e257c

Please sign in to comment.