Skip to content

Commit

Permalink
Add hotrod in release and push all tags (#2812)
Browse files Browse the repository at this point in the history
  • Loading branch information
Ashmita152 authored Feb 12, 2021
1 parent c8b8168 commit 061c669
Show file tree
Hide file tree
Showing 23 changed files with 25 additions and 161 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci-all-in-one-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ jobs:
run: make install-ci

- name: Build, test, and publish all-in-one image
run: bash scripts/travis/build-all-in-one-image.sh
run: bash scripts/build-all-in-one-image.sh
env:
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
QUAY_TOKEN: ${{ secrets.QUAY_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/ci-cassandra.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ jobs:
go-version: ^1.15

- name: Run cassandra integration tests
run: bash scripts/travis/cassandra-integration-test.sh
run: bash scripts/cassandra-integration-test.sh
2 changes: 1 addition & 1 deletion .github/workflows/ci-crossdock.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:
matrix:
steps:
- name: crossdock
cmd: bash scripts/travis/build-crossdock.sh
cmd: bash scripts/build-crossdock.sh
- name: crossdock-otel
cmd: make build-crossdock crossdock-otel
name: ${{ matrix.steps.name }}
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/ci-docker-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ jobs:
run: make docker

- name: Upload docker images
run: bash scripts/travis/upload-all-docker-images.sh
run: bash scripts/upload-all-docker-images.sh
env:
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
QUAY_TOKEN: ${{ secrets.QUAY_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/ci-elasticsearch.yml
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ jobs:
run: make install-ci

- name: Run elasticsearch integration tests
run: bash scripts/travis/es-integration-test.sh ${{ matrix.version.image }}
run: bash scripts/es-integration-test.sh ${{ matrix.version.image }}
2 changes: 1 addition & 1 deletion .github/workflows/ci-hotrod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:
run: make install-ci

- name: Build, test, and publish hotrod image
run: bash scripts/travis/hotrod-integration-test.sh
run: bash scripts/hotrod-integration-test.sh
env:
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
QUAY_TOKEN: ${{ secrets.QUAY_TOKEN }}
2 changes: 1 addition & 1 deletion .github/workflows/ci-kafka.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,4 @@ jobs:
go-version: ^1.15

- name: Run kafka integration tests
run: bash scripts/travis/kafka-integration-test.sh
run: bash scripts/kafka-integration-test.sh
12 changes: 9 additions & 3 deletions .github/workflows/ci-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ jobs:

- name: Package binaries
id: package-binaries
run: bash scripts/travis/package-deploy.sh
run: bash scripts/package-deploy.sh
if: steps.build-binaries.outcome == 'success'

- name: Upload binaries
Expand All @@ -54,14 +54,20 @@ jobs:
run: make docker

- name: Upload docker images
run: bash scripts/travis/upload-all-docker-images.sh
run: bash scripts/upload-all-docker-images.sh
if: steps.build-images.outcome == 'success'
env:
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
QUAY_TOKEN: ${{ secrets.QUAY_TOKEN }}

- name: Build, test, and publish all-in-one image
run: bash scripts/travis/build-all-in-one-image.sh
run: bash scripts/build-all-in-one-image.sh
env:
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
QUAY_TOKEN: ${{ secrets.QUAY_TOKEN }}

- name: Build, test, and publish hotrod image
run: bash scripts/hotrod-integration-test.sh
env:
DOCKERHUB_TOKEN: ${{ secrets.DOCKERHUB_TOKEN }}
QUAY_TOKEN: ${{ secrets.QUAY_TOKEN }}
104 changes: 0 additions & 104 deletions .travis.yml

This file was deleted.

3 changes: 1 addition & 2 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -87,8 +87,7 @@ github.com/jaegertracing/jaeger
spanstore/ - SpanReader / SpanWriter implementations
dependencystore/
elasticsearch/ - ES implementations of storage APIs
scripts/ - Miscellaneous project scripts, e.g. license update script
travis/ - Travis scripts called in .travis.yml
scripts/ - Miscellaneous project scripts, e.g. github action and license update script
storage/
spanstore/ - SpanReader / SpanWriter interfaces
dependencystore/
Expand Down
4 changes: 2 additions & 2 deletions plugin/storage/es/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -50,9 +50,9 @@ To locally test the ElasticSearch storage plugin,
* have [ElasticSearch](https://www.elastic.co/guide/en/elasticsearch/reference/current/setup.html) running on port 9200
* run `STORAGE=es make storage-integration-test` in the top folder.

All integration tests also run on pull request via Travis. This integration test is against ElasticSearch v5.4.0.
All integration tests also run on pull request via GitHub Actions. This integration test is against ElasticSearch v5.6.16, v6.8.2 and v7.3.0.

* The script used in Travis can be found under `./travis/es-integration-test.sh`,
* The script used in GitHub Actions can be found under `scripts/es-integration-test.sh`,
and that script be run from the top folder to integration test ElasticSearch as well.
This script requires Docker to be running.

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ set -exu
BRANCH=${BRANCH:?'missing BRANCH env var'}
# Set default GOARCH variable to the host GOARCH, the target architecture can
# be overrided by passing architecture value to the script:
# `GOARCH=<target arch> ./scripts/travis/build-all-in-one-image.sh`.
# `GOARCH=<target arch> ./scripts/build-all-in-one-image.sh`.
GOARCH=${GOARCH:-$(go env GOARCH)}

expected_version="v10"
Expand Down Expand Up @@ -39,7 +39,7 @@ upload_to_docker() {
if [[ "$BRANCH" == "master" || $BRANCH =~ ^v[0-9]+\.[0-9]+\.[0-9]+$ ]]; then
echo "upload $1 to dockerhub/quay.io"
REPO=$1
bash scripts/travis/upload-to-registry.sh $REPO
bash scripts/upload-to-registry.sh $REPO
else
echo 'skip docker images upload for PR'
fi
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ fi
# docker image has been build when running the crossdock
REPO=jaegertracing/test-driver
docker tag $REPO:latest $REPO:$COMMIT
bash scripts/travis/upload-to-registry.sh $REPO
bash scripts/upload-to-registry.sh $REPO
File renamed without changes.
File renamed without changes.
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,4 @@ else
exit 0
fi

bash scripts/travis/upload-to-registry.sh $REPO
bash scripts/upload-to-registry.sh $REPO
File renamed without changes.
File renamed without changes.
12 changes: 0 additions & 12 deletions scripts/travis/build-docker-images.sh

This file was deleted.

12 changes: 0 additions & 12 deletions scripts/travis/install-crossdock-deps.sh

This file was deleted.

13 changes: 0 additions & 13 deletions scripts/travis/install-ui-deps.sh

This file was deleted.

Original file line number Diff line number Diff line change
Expand Up @@ -38,5 +38,5 @@ jaeger_components=(
for component in "${jaeger_components[@]}"
do
REPO="jaegertracing/jaeger-${component}"
bash scripts/travis/upload-to-registry.sh $REPO
bash scripts/upload-to-registry.sh $REPO
done
Original file line number Diff line number Diff line change
Expand Up @@ -85,7 +85,7 @@ upload_images() {
docker push ${registry}/${image}:latest
;;
*)
docker push ${registry}/${image}
docker push --all-tags ${registry}/${image}
;;
esac

Expand Down

0 comments on commit 061c669

Please sign in to comment.