-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Monitor Tab - show 95 Latency in a more readable time-unit #893
Conversation
Signed-off-by: nofar9792 <[email protected]>
Signed-off-by: nofar9792 <[email protected]>
…o latency-unit-time
Codecov Report
@@ Coverage Diff @@
## main #893 +/- ##
=======================================
Coverage 95.29% 95.29%
=======================================
Files 240 240
Lines 7466 7466
Branches 1866 1866
=======================================
Hits 7115 7115
Misses 345 345
Partials 6 6
Continue to review full report at Codecov.
|
Don't have a problem with this PR itself, but I am not a fan of this Could we fix this function to:
|
lower-case units? change |
change timeConversion. It's weird that it mixes cases between us/ms and Sec/Hrs |
Signed-off-by: nofar9792 <[email protected]>
done |
@yurishkuro ping |
Signed-off-by: nofar9792 <[email protected]>
…er-ui into latency-unit-time
Which problem is this PR solving?
Resolves #892
Short description of the changes
before:
after: