Monitor Tab - Crosshair Color is too light #888
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nofar9792 <[email protected]>
nofar9792
requested review from
everett980,
rubenvp8510 and
tiffon
as code owners
yurishkuro
reviewed
Feb 20, 2022
| @@ -163,7 +163,7 @@ export class ServiceGraphImpl extends React.PureComponent<TProps> { | |||
| <YAxis /> | |||
| {this.renderLines()} | |||
| <Crosshair values={this.state.crosshairValues}> | |||
| <div style={{ width: 140 }}> | |||
| <div style={{ width: 140, color: '#6B6B76' }}> | |||
There was a problem hiding this comment.
Shouldn't this be changed in a style sheet somewhere instead of local override?
There was a problem hiding this comment.
moved the width and the color to css.
thanks
added 2 commits
February 21, 2022 21:12
Signed-off-by: nofar9792 <[email protected]>
yurishkuro
approved these changes
Feb 21, 2022
Codecov Report
@@ Coverage Diff @@
## main #888 +/- ##
==========================================
- Coverage 95.36% 95.29% -0.07%
==========================================
Files 240 240
Lines 7460 7460
Branches 1865 1865
==========================================
- Hits 7114 7109 -5
- Misses 340 345 +5
Partials 6 6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Resolves #887
Short description of the changes
use darker gray
after:
