Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widen date input to avoid clipping, fixes #864 #867

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

bobrik
Copy link
Contributor

@bobrik bobrik commented Jan 14, 2022

Which problem is this PR solving?

Resolves #864.

Short description of the changes

Before:

Lookback

After:

Lookback

@codecov
Copy link

codecov bot commented Jan 14, 2022

Codecov Report

Merging #867 (29b7de5) into main (96cdbba) will decrease coverage by 0.14%.
The diff coverage is n/a.

❗ Current head 29b7de5 differs from pull request most recent head 76c1a9d. Consider uploading reports for the commit 76c1a9d to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
- Coverage   95.41%   95.26%   -0.15%     
==========================================
  Files         240      240              
  Lines        7460     7460              
  Branches     1865     1865              
==========================================
- Hits         7118     7107      -11     
- Misses        336      347      +11     
  Partials        6        6              
Impacted Files Coverage Δ
...er-ui/src/components/SearchTracePage/SearchForm.js 92.10% <ø> (ø)
...mponents/TracePage/TraceStatistics/tableValues.tsx 93.79% <0.00%> (-3.80%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96cdbba...76c1a9d. Read the comment docs.

Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@yurishkuro yurishkuro merged commit 72191f1 into jaegertracing:main Jan 14, 2022
@bobrik bobrik deleted the ivan/no-date-clipping branch January 15, 2022 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Date input is clipped in custom time selection
2 participants