Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Endless loop while calculating overlay between spans in traceStatistics View #843

Merged
merged 2 commits into from
Nov 25, 2021

Conversation

vvvprabhakar
Copy link
Contributor

@vvvprabhakar vvvprabhakar commented Nov 1, 2021

Which problem is this PR solving?

Short description of the changes

  • Added a condition for duration to be not negative

@codecov
Copy link

codecov bot commented Nov 1, 2021

Codecov Report

Merging #843 (a37a930) into master (9068a11) will increase coverage by 0.17%.
The diff coverage is 100.00%.

❗ Current head a37a930 differs from pull request most recent head 4fb4bad. Consider uploading reports for the commit 4fb4bad to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #843      +/-   ##
==========================================
+ Coverage   95.32%   95.49%   +0.17%     
==========================================
  Files         240      240              
  Lines        7458     7460       +2     
  Branches     1811     1812       +1     
==========================================
+ Hits         7109     7124      +15     
+ Misses        343      330      -13     
  Partials        6        6              
Impacted Files Coverage Δ
...mponents/TracePage/TraceStatistics/tableValues.tsx 98.96% <100.00%> (+4.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9068a11...4fb4bad. Read the comment docs.

@vvvprabhakar vvvprabhakar force-pushed the issue-840 branch 2 times, most recently from 72a5aa0 to 9565b7f Compare November 1, 2021 05:47
Signed-off-by: vvvprabhakar <[email protected]>
@vvvprabhakar vvvprabhakar changed the title ISSUE-840 Fix: Endless loop while calculating overlay between spans in traceStatistics View Nov 1, 2021
@yurishkuro yurishkuro enabled auto-merge (squash) November 25, 2021 20:26
@yurishkuro yurishkuro merged commit 42b39c9 into jaegertracing:master Nov 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Infinite loop while calculating the overlay in traceStatistics
2 participants