-
Notifications
You must be signed in to change notification settings - Fork 485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable regexes and functions in link patterns #817
Enable regexes and functions in link patterns #817
Conversation
Signed-off-by: yoave23 <[email protected]>
Signed-off-by: yoave23 <[email protected]>
Signed-off-by: yoave23 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #817 +/- ##
==========================================
- Coverage 95.22% 95.19% -0.03%
==========================================
Files 231 231
Lines 7097 7103 +6
Branches 1706 1709 +3
==========================================
+ Hits 6758 6762 +4
- Misses 333 335 +2
Partials 6 6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add documentation somewhere.
FWIW, I see that the README has a UI Configuration
section that simply points to the website, I wonder if it would've been better to do the opposite, i.e. keep docs in this repo (e.g. plexus plugin has an extensive README, as well as tracking API) and point the docs here.
can it wait till I submit a PR for #729? should be ready by the end of the week |
Which problem is this PR solving?
Unblocked by JSON config support from #123
Short description of the changes
Allow matching link patterns with regular expressions or functions
example with regex, this will apply the pattern all tags:
example for function config: