Allow customizing trace quality menu title #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 10, 2020 15:55
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #592 +/- ##
==========================================
+ Coverage 93.54% 93.56% +0.01%
==========================================
Files 217 217
Lines 5296 5296
Branches 1362 1362
==========================================
+ Hits 4954 4955 +1
+ Misses 301 300 -1
Partials 41 41
Continue to review full report at Codecov.
|
everett980
requested changes
Jun 10, 2020
| @@ -64,7 +64,7 @@ if (getConfigValue('qualityMetrics.menuEnabled')) { | |||
| NAV_LINKS.push({ | |||
| to: qualityMetrics.getUrl(), | |||
| matches: qualityMetrics.matches, | |||
| text: 'Quality Metrics', | |||
| text: getConfigValue('qualityMetrics.menuLabel') || 'Trace Quality', | |||
There was a problem hiding this comment.
Please update the config type definition here
and instead of || 'Trace Quality' please use the default config object
added 4 commits
June 10, 2020 16:48
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
Signed-off-by: Yuri Shkuro <[email protected]>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
* Allow customizing Quality Metrics menu title Signed-off-by: Yuri Shkuro <[email protected]> * Change default title Signed-off-by: Yuri Shkuro <[email protected]> * Move defaults Signed-off-by: Yuri Shkuro <[email protected]> * prettier Signed-off-by: Yuri Shkuro <[email protected]> * comment Signed-off-by: Yuri Shkuro <[email protected]> * default Signed-off-by: Yuri Shkuro <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And change default title to Trace Quality