Avoid the horizontal scrollbar (KeyValueTable) #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smanolloff
changed the title
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
==========================================
+ Coverage 93.55% 93.57% +0.01%
==========================================
Files 217 217
Lines 5289 5289
Branches 1360 1360
==========================================
+ Hits 4948 4949 +1
+ Misses 300 299 -1
Partials 41 41
Continue to review full report at Codecov.
|
smanolloff
force-pushed
the
avoid-horizontal-scrollbar
branch
from
14cd771
to
0f36017
Compare
Signed-off-by: Simeon Manolov <[email protected]>
smanolloff
force-pushed
the
avoid-horizontal-scrollbar
branch
from
0f36017
to
142f70f
Compare
|
I want to point out that I cannot explain why this fix works, it was a trial-and-error. |
|
I think it's a reasonable change, don't see much value in breaking on words only, it could always cause scrolling issues. |
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…cing#586) Signed-off-by: Simeon Manolov <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
The "copy" icon should not cause a horizontal scroll to appear on the expanded KeyValue table.
There is also no need to treat the values as linguistic composites of non-breakable words - they can just as likely be just strings of symbols, for which break-word would actually degrade, rather than improve visual perception.
After the change: