Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GA filter category copy-paste #404

Merged
merged 1 commit into from
Jul 3, 2019

Conversation

everett980
Copy link
Collaborator

We aren't yet using the GA Event Categories (just the Event Action), but as we do more GA tracking we may want to, and before that point this should be updated.

@everett980 everett980 requested a review from tiffon July 3, 2019 18:43
@codecov
Copy link

codecov bot commented Jul 3, 2019

Codecov Report

Merging #404 into master will decrease coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #404      +/-   ##
==========================================
- Coverage   89.82%   89.77%   -0.06%     
==========================================
  Files         170      170              
  Lines        3842     3842              
  Branches      869      869              
==========================================
- Hits         3451     3449       -2     
- Misses        355      357       +2     
  Partials       36       36
Impacted Files Coverage Δ
...jaeger-ui/src/components/TracePage/index.track.tsx 100% <100%> (ø) ⬆️
...eViewer/TimelineHeaderRow/TimelineViewingLayer.tsx 88.13% <0%> (-3.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bcc8fa6...5c9acbe. Read the comment docs.

Copy link
Member

@tiffon tiffon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doh!

@tiffon tiffon merged commit 59f952d into jaegertracing:master Jul 3, 2019
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Fix GA filter category copy-paste
Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants