Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes dragging on the minimap in trace timeline #357

Merged
merged 1 commit into from
Mar 24, 2019

Conversation

rubenvp8510
Copy link
Collaborator

Which problem is this PR solving?

Short description of the changes

  • Set/Update view range object time attribute correctly

@codecov
Copy link

codecov bot commented Mar 21, 2019

Codecov Report

Merging #357 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #357      +/-   ##
==========================================
+ Coverage   90.75%   90.76%   +<.01%     
==========================================
  Files         152      152              
  Lines        3290     3292       +2     
  Branches      666      666              
==========================================
+ Hits         2986     2988       +2     
  Misses        249      249              
  Partials       55       55
Impacted Files Coverage Δ
...ckages/jaeger-ui/src/components/TracePage/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 35f1cbd...49c9396. Read the comment docs.

Copy link
Member

@tiffon tiffon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@tiffon tiffon merged commit 8359f8a into jaegertracing:master Mar 24, 2019
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Fixes dragging on the minimap in trace timeline
Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants