Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unfocus unit test (doh!) #298

Merged
merged 1 commit into from
Dec 20, 2018
Merged

Unfocus unit test (doh!) #298

merged 1 commit into from
Dec 20, 2018

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Dec 20, 2018

Remnant of debugging a test.

Signed-off-by: Joe Farro <[email protected]>
@ghost ghost assigned tiffon Dec 20, 2018
@ghost ghost added the review label Dec 20, 2018
@codecov
Copy link

codecov bot commented Dec 20, 2018

Codecov Report

Merging #298 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #298   +/-   ##
=======================================
  Coverage   82.16%   82.16%           
=======================================
  Files         141      141           
  Lines        3100     3100           
  Branches      645      645           
=======================================
  Hits         2547     2547           
  Misses        439      439           
  Partials      114      114
Impacted Files Coverage Δ
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js 87.03% <0%> (-1.86%) ⬇️
...nents/TracePage/TracePageHeader/TracePageHeader.js 93.33% <0%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 53937eb...ae93e08. Read the comment docs.

@tiffon
Copy link
Member Author

tiffon commented Dec 20, 2018

Merging without review as this is scoped to a test, is removing a typo and puts master in a more resilient state.

@tiffon tiffon merged commit ab69885 into master Dec 20, 2018
@ghost ghost removed the review label Dec 20, 2018
everett980 pushed a commit to everett980/jaeger-ui that referenced this pull request Jan 16, 2019
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Everett Ross <[email protected]>
@yurishkuro yurishkuro deleted the unfocus-test branch January 29, 2020 15:08
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: vvvprabhakar <[email protected]>
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Everett Ross <[email protected]>

Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant