Ability to open additional menu links in same tab (Resolves #275) #278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Vitaliy Zabolotskyy <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #278 +/- ##
=========================================
Coverage ? 82.58%
=========================================
Files ? 141
Lines ? 3152
Branches ? 654
=========================================
Hits ? 2603
Misses ? 435
Partials ? 114
Continue to review full report at Codecov.
|
yurishkuro
reviewed
Nov 17, 2018
| @@ -30,6 +30,7 @@ describe('<TopNav>', () => { | |||
| { | |||
| label: 'Twitter', | |||
| url: 'https://twitter.com/JaegerTracing', | |||
| openInSameTab: true, | |||
There was a problem hiding this comment.
does this make a difference?
There was a problem hiding this comment.
In renders the nested menu items test, there is assertion if this is passed further.
I tried to make a test for rendered dropdown, but I just don't know, how to do it.
Signed-off-by: Vitaliy Zabolotskyy <[email protected]>
Signed-off-by: Vitaliy Zabolotskyy <[email protected]>
Signed-off-by: Vitaliy Zabolotskyy <[email protected]>
tiffon
suggested changes
Nov 30, 2018
Signed-off-by: Joe Farro <[email protected]>
ghost
assigned
tiffon
previously approved these changes
Jan 6, 2019
everett980
approved these changes
Jan 7, 2019
Signed-off-by: Joe Farro <[email protected]>
everett980
pushed a commit
to everett980/jaeger-ui
that referenced
this pull request
Jan 16, 2019
…cing#275) (jaegertracing#278) * Ability to open additional menu links in same tab (jaegertracing#275) Signed-off-by: Vitaliy Zabolotskyy <[email protected]> * Add negative test case Signed-off-by: Vitaliy Zabolotskyy <[email protected]> * Add helper function to create item links Signed-off-by: Vitaliy Zabolotskyy <[email protected]> * Fix no-use-before-define lint error Signed-off-by: Vitaliy Zabolotskyy <[email protected]> * Use anchorTarget in custom menu configuration Signed-off-by: Joe Farro <[email protected]> * Fix typo in test case Signed-off-by: Joe Farro <[email protected]> Signed-off-by: Everett Ross <[email protected]>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…cing#275) (jaegertracing#278) * Ability to open additional menu links in same tab (jaegertracing#275) Signed-off-by: Vitaliy Zabolotskyy <[email protected]> * Add negative test case Signed-off-by: Vitaliy Zabolotskyy <[email protected]> * Add helper function to create item links Signed-off-by: Vitaliy Zabolotskyy <[email protected]> * Fix no-use-before-define lint error Signed-off-by: Vitaliy Zabolotskyy <[email protected]> * Use anchorTarget in custom menu configuration Signed-off-by: Joe Farro <[email protected]> * Fix typo in test case Signed-off-by: Joe Farro <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this pull request
Jul 5, 2021
…cing#275) (jaegertracing#278) * Ability to open additional menu links in same tab (jaegertracing#275) Signed-off-by: Vitaliy Zabolotskyy <[email protected]> * Add negative test case Signed-off-by: Vitaliy Zabolotskyy <[email protected]> * Add helper function to create item links Signed-off-by: Vitaliy Zabolotskyy <[email protected]> * Fix no-use-before-define lint error Signed-off-by: Vitaliy Zabolotskyy <[email protected]> * Use anchorTarget in custom menu configuration Signed-off-by: Joe Farro <[email protected]> * Fix typo in test case Signed-off-by: Joe Farro <[email protected]> Signed-off-by: Everett Ross <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Vitaliy Zabolotskyy [email protected]
Which problem is this PR solving?
Resolves #275
Adds option to ui-config, so added link can be opened in the same tab
Short description of the changes
Added corresponding boolean field to ConfigMenuItem and setting link target accordingly.