Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collapse all issues #264

Merged
merged 3 commits into from
Oct 11, 2018
Merged

Fix collapse all issues #264

merged 3 commits into from
Oct 11, 2018

Conversation

tiffon
Copy link
Member

@tiffon tiffon commented Oct 8, 2018

Which problem is this PR solving?

Resolves issues with the expand and collapse.

Fix #259.

Fix #260.

Short description of the changes

Avert JS errors and scrolling problems when using collapse all.

@ghost ghost assigned tiffon Oct 8, 2018
@ghost ghost added the review label Oct 8, 2018
Signed-off-by: Joe Farro <[email protected]>
@codecov
Copy link

codecov bot commented Oct 8, 2018

Codecov Report

Merging #264 into master will increase coverage by 0.07%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #264      +/-   ##
==========================================
+ Coverage   77.05%   77.12%   +0.07%     
==========================================
  Files         135      135              
  Lines        2950     2955       +5     
  Branches      613      613              
==========================================
+ Hits         2273     2279       +6     
+ Misses        534      533       -1     
  Partials      143      143
Impacted Files Coverage Δ
...elineViewer/TimelineHeaderRow/TimelineHeaderRow.js 100% <ø> (ø) ⬆️
...ckages/jaeger-ui/src/components/TracePage/index.js 65.15% <0%> (-0.5%) ⬇️
...ts/TracePage/TraceTimelineViewer/ListView/index.js 96.09% <100%> (ø) ⬆️
...elineViewer/TimelineHeaderRow/TimelineCollapser.js 83.33% <83.33%> (-16.67%) ⬇️
...neViewer/TimelineHeaderRow/TimelineViewingLayer.js 92.59% <0%> (+1.85%) ⬆️
packages/jaeger-ui/src/utils/date.js 90% <0%> (+5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d7c7e10...28c58c5. Read the comment docs.

@yurishkuro yurishkuro removed their request for review October 8, 2018 20:20
@yurishkuro yurishkuro removed their request for review October 10, 2018 16:54
packages/jaeger-ui/package.json Show resolved Hide resolved
Copy link

@simonrobb simonrobb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tiffon tiffon merged commit 6bbe0ef into master Oct 11, 2018
@ghost ghost removed the review label Oct 11, 2018
@rogueai
Copy link

rogueai commented Nov 3, 2018

Hi, I was trying out the latest code, and I found a weird issue where the dragger line extends past its bounds, essentially covering the page's full height:
screenshot 2018-11-03 at 22 39 03
I think this PR might have introduced the issue as reverting the commit seems to work fine.

@yurishkuro
Copy link
Member

Thanks for reporting - booked as #269

@yurishkuro yurishkuro deleted the issue-259-collapse-range-error branch January 29, 2020 15:08
vvvprabhakar pushed a commit to vvvprabhakar/jaeger-ui that referenced this pull request Jul 5, 2021
Investigated the license issues, manually, and they're fine.

* Upgrade to ant-design 3.8.0

Signed-off-by: Joe Farro <[email protected]>

* Fix issues with expand / collapse - jaegertracing#259 and jaegertracing#260

Signed-off-by: Joe Farro <[email protected]>

* Use yarn registry

Signed-off-by: Joe Farro <[email protected]>

Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants