-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix collapse all issues #264
Conversation
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Signed-off-by: Joe Farro <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #264 +/- ##
==========================================
+ Coverage 77.05% 77.12% +0.07%
==========================================
Files 135 135
Lines 2950 2955 +5
Branches 613 613
==========================================
+ Hits 2273 2279 +6
+ Misses 534 533 -1
Partials 143 143
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for reporting - booked as #269 |
Investigated the license issues, manually, and they're fine. * Upgrade to ant-design 3.8.0 Signed-off-by: Joe Farro <[email protected]> * Fix issues with expand / collapse - jaegertracing#259 and jaegertracing#260 Signed-off-by: Joe Farro <[email protected]> * Use yarn registry Signed-off-by: Joe Farro <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Which problem is this PR solving?
Resolves issues with the expand and collapse.
Fix #259.
Fix #260.
Short description of the changes
Avert JS errors and scrolling problems when using collapse all.