upgraded jsdom to v26 #2594
Closed
upgraded jsdom to v26 #2594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this is my first pr to jaeger, tell me If there are any problems to this I will try to solve it as soon as possible. |
Signed-off-by: coderboy-yash <[email protected]>
coderboy-yash
force-pushed
the
upgrade-js-dom
branch
from
4777b1c to
58c5315
Compare
|
@jkowall @yurishkuro please review my pr |
yurishkuro
reviewed
Jan 19, 2025
| @@ -22,7 +22,7 @@ | |||
| "eslint-plugin-jsx-a11y": "^6.8.0", | |||
| "eslint-plugin-react": "7.37.1", | |||
| "husky": "9.1.0", | |||
| "jsdom": "25.0.1", | |||
| "jsdom": "^26.0.0", | |||
There was a problem hiding this comment.
how is this different from automated PR #2584 which does not pass CI?
|
this just replicates the automated PR #2584 which is already known to fail. Closing to reduce noise. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
-resolves #2585
Description of the changes
How was this change tested?
Checklist
jaeger:make lint testjaeger-ui:npm run lintandnpm run test