Make dependencies tab configurable #122
Conversation
Signed-off-by: Pavol Loffay <[email protected]>
| @@ -79,11 +83,11 @@ export default function TopNav(props: TopNavProps) { | |||
| <div className="ui input"> | |||
| <TraceIDSearchInput /> | |||
| </div> | |||
| {NAV_LINKS.map(({ key, to, text }) => | |||
| {NAV_LINKS.map(({ key, to, text }) => ( | |||
There was a problem hiding this comment.
husky > npm run -s precommit (node v6.11.2)
does this change
There was a problem hiding this comment.
@pavolloffay I don't follow... can you elaborate?
There was a problem hiding this comment.
that this changes it done automatically via git hooks not by me
|
@pavolloffay could you please explain the objective / use case? It would also go to documentation of the new property. |
|
The motivation behind this is that dependency screen in production deployment requires an external process. Some deployments don't use it. In other words it's optional. |
| @@ -79,11 +83,11 @@ export default function TopNav(props: TopNavProps) { | |||
| <div className="ui input"> | |||
| <TraceIDSearchInput /> | |||
| </div> | |||
| {NAV_LINKS.map(({ key, to, text }) => | |||
| {NAV_LINKS.map(({ key, to, text }) => ( | |||
There was a problem hiding this comment.
@pavolloffay I don't follow... can you elaborate?
src/components/App/TopNav.js
Outdated
| key: 'search', | ||
| to: prefixUrl('/search'), | ||
| text: 'Search', | ||
| }, | ||
| ]; | ||
|
|
||
| if (getConfig().depsMenuEnabled === true) { |
There was a problem hiding this comment.
This can just be
if (getConfig().depsMenuEnabled) {Or is there a reason to fail if truthy but not strictly true ?
src/constants/default-config.js
Outdated
| @@ -46,4 +46,5 @@ export default deepFreeze({ | |||
| ], | |||
| }, | |||
| ], | |||
| depsMenuEnabled: true, | |||
There was a problem hiding this comment.
Can this be renamed to dependenciesMenuEnabled ?
Signed-off-by: Pavol Loffay <[email protected]>
|
PR updated |
Signed-off-by: vvvprabhakar <[email protected]>
cc @objectiser