Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent wrapping of the timeline tick label text #1117

Merged
merged 1 commit into from
Feb 5, 2023

Conversation

SOF3
Copy link
Contributor

@SOF3 SOF3 commented Dec 14, 2022

When the timeline is more than one minute, the ticks would line wrap:
image

Setting width to max-content solves this problem:
image

@yurishkuro
Copy link
Member

I am worried about tweaking css settings like that, what if it has other unintended consequences?

I would rather make a change in the code to skip the space and render time as 8m8s

@SOF3
Copy link
Contributor Author

SOF3 commented Dec 15, 2022

What about using white-space: nowrap? Should have the equivalent effect.

@yurishkuro
Copy link
Member

That sounds better

Signed-off-by: Jonathan Chan Kwan Yin <[email protected]>
@yurishkuro yurishkuro changed the title Set timeline tick label width to max-content Prevent wrapping of the timeline tick label text Feb 5, 2023
@yurishkuro yurishkuro merged commit 2bf0392 into jaegertracing:main Feb 5, 2023
@yurishkuro
Copy link
Member

Sorry for delay, thanks for contributing.

@SOF3 SOF3 deleted the patch-1 branch February 6, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants