-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trace - Indent guides in span-name column to indicate span ancestry #172
Labels
Comments
+1 for guidelines |
everett980
added a commit
to everett980/jaeger-ui
that referenced
this issue
Dec 18, 2018
Signed-off-by: Everett Ross <[email protected]>
tiffon
pushed a commit
that referenced
this issue
Jan 4, 2019
* Add indent guides to trace timeline view (#172) Signed-off-by: Everett Ross <[email protected]> * Add tests for connect functions, add more flow types Signed-off-by: Everett Ross <[email protected]> * Consolidate ducks, remove redudant PropTypes, add event type Signed-off-by: Everett Ross <[email protected]> * Rename hoverSpanId to hoverIndentGuideId Signed-off-by: Everett Ross <[email protected]> * Derive props from span, use dataset over getAttribute Signed-off-by: Everett Ross <[email protected]>
everett980
added a commit
to everett980/jaeger-ui
that referenced
this issue
Jan 16, 2019
…racing#297) * Add indent guides to trace timeline view (jaegertracing#172) Signed-off-by: Everett Ross <[email protected]> * Add tests for connect functions, add more flow types Signed-off-by: Everett Ross <[email protected]> * Consolidate ducks, remove redudant PropTypes, add event type Signed-off-by: Everett Ross <[email protected]> * Rename hoverSpanId to hoverIndentGuideId Signed-off-by: Everett Ross <[email protected]> * Derive props from span, use dataset over getAttribute Signed-off-by: Everett Ross <[email protected]> Signed-off-by: Everett Ross <[email protected]>
Fixed in #297. |
ghost
removed
the
backlog
label
Mar 7, 2019
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this issue
Jul 5, 2021
…racing#297) * Add indent guides to trace timeline view (jaegertracing#172) Signed-off-by: Everett Ross <[email protected]> * Add tests for connect functions, add more flow types Signed-off-by: Everett Ross <[email protected]> * Consolidate ducks, remove redudant PropTypes, add event type Signed-off-by: Everett Ross <[email protected]> * Rename hoverSpanId to hoverIndentGuideId Signed-off-by: Everett Ross <[email protected]> * Derive props from span, use dataset over getAttribute Signed-off-by: Everett Ross <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
vvvprabhakar
pushed a commit
to vvvprabhakar/jaeger-ui
that referenced
this issue
Jul 5, 2021
…racing#297) * Add indent guides to trace timeline view (jaegertracing#172) Signed-off-by: Everett Ross <[email protected]> * Add tests for connect functions, add more flow types Signed-off-by: Everett Ross <[email protected]> * Consolidate ducks, remove redudant PropTypes, add event type Signed-off-by: Everett Ross <[email protected]> * Rename hoverSpanId to hoverIndentGuideId Signed-off-by: Everett Ross <[email protected]> * Derive props from span, use dataset over getAttribute Signed-off-by: Everett Ross <[email protected]> Signed-off-by: Everett Ross <[email protected]> Signed-off-by: vvvprabhakar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The approach that initially comes to mind is to have low-contrast, persistent indent guides visible at all times and to highlight the relevant indent guides on hover (e.g. ancestors of the span the mouse is over). In the screenshot below, the all of the indent guides of the
return
statement and subsequent lines would still be visible, but they would be the low-contrast variation instead of emphasized with orange.The text was updated successfully, but these errors were encountered: