[chore]: Fix eslint warnings #1608

punithnayak · 2023-07-27T17:49:46Z

What happened?

There some lint warnings shown

Steps to reproduce

Go to the root dir of jaeger-UI
run yarn lint

Expected behavior

There should be no eslint warnings

Relevant log output

`[eslint       ] 
[eslint       ] /jaeger-ui/packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.test.js
[eslint       ]   178:23  warning  Unexpected unnamed function  func-names
[eslint       ] 
[eslint       ] /jaeger-ui/packages/jaeger-ui/src/components/SearchTracePage/SearchResults/index.tsx
[eslint       ]   117:18  warning  'createBlob' was used before it was defined  @typescript-eslint/no-use-before-define
[eslint       ] 
[eslint       ] /jaeger-ui/packages/jaeger-ui/src/components/TracePage/TraceStatistics/index.tsx
[eslint       ]   284:13  warning  Avoid non-native interactive elements. If using native HTML is not possible, add an appropriate role and support for tabbing, mouse, keyboard, and touch inputs to an interactive content element  jsx-a11y/no-static-element-interactions
[eslint       ] 
[eslint       ] /jaeger-ui/packages/jaeger-ui/src/selectors/span.js
[eslint       ]   15:1  warning  Prefer default export on a file with single export  import/prefer-default-export
[eslint       ] 
[eslint       ] ✖ 4 problems (0 errors, 4 warnings)
[eslint       ]

Screenshot

Additional context

No response

Jaeger backend version

No response

SDK

No response

Pipeline

No response

Stogage backend

No response

Operating system

No response

Deployment model

No response

Deployment configs

No response

The text was updated successfully, but these errors were encountered:

punithnayak · 2023-07-27T17:50:55Z

I am also planning to add lint check during ci/cd to prevent further lint warnings/errors in the code

yurishkuro · 2023-07-29T19:22:28Z

Some of the warnings are due to outdated APIs.

shuence · 2023-08-10T16:29:22Z

@yurishkuro Anyone Working on this? if not can you assign this to me?

yurishkuro · 2023-08-10T16:43:25Z

you can see linked issues/PRs for parts that are being work on. We do not assign issues.

## Which problem is this PR solving? - Resolves #1613 - Part of #1608 ## Description of the changes - Update code lines to resolve lint check warnings ## How was this change tested? - `yarn run esilnt` ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [ ] I have added unit tests for the new functionality --------- Signed-off-by: Tony Jin <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>

## Which problem is this PR solving? - Too many linter warnings about empty functions, they are not expecially helpful or critical - Part of #1608 ## Description of the changes - turn off `no-empty-function` rule - Fix some other warnings in DeepDependencies ## How was this change tested? - yarn lint Signed-off-by: Yuri Shkuro <[email protected]>

Signed-off-by: priyanshu-kun <[email protected]>

## Which problem is this PR solving? - Resolves: #1608 ## Description of the changes - I fixed eslint warnings in our codebase, which we are got after running yarn lint. This improves code quality, consistency, and reduces technical debt. ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: priyanshu-kun <[email protected]> Signed-off-by: Priyanshu Sharma <[email protected]> Signed-off-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]> Co-authored-by: Yuri Shkuro <[email protected]>

## Which problem is this PR solving? - Resolves part of no-unused-vars warnings for #1608 ## Description of the changes - Unused variables have been removed ## How was this change tested? - By running "yarn lint" command ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test`

## Which problem is this PR solving? - Resolves part of no-unused-vars warnings for #1608 ## Description of the changes - Fixed ESlint warnings for Function, Boolean and String types ## How was this change tested? - By running "yarn lint" command ## Checklist - [x] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [x] I have signed all commits - [x] I have added unit tests for the new functionality - [x] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test`

## Which problem is this PR solving? Fixes part of #1608 ## Description of the changes - Added the minimal types needed to fix the linting warnings - Replaced `{}` with the `object` type ## How was this change tested? - Ran `yarn lint` locally ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Eshaan Aggarwal <[email protected]>

## Which problem is this PR solving? Fixes part of jaegertracing#1608 ## Description of the changes - Added the minimal types needed to fix the linting warnings - Replaced `{}` with the `object` type ## How was this change tested? - Ran `yarn lint` locally ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Eshaan Aggarwal <[email protected]>

## Which problem is this PR solving? Fixes part of #1608 ## Description of the changes - Fixed some more ESLint warning by adding relevant type annotations - `68` warnings to go after this PR ## How was this change tested? - Ran `yarn lint` locally ## Checklist - [X] I have read https://github.com/jaegertracing/jaeger/blob/master/CONTRIBUTING_GUIDELINES.md - [X] I have signed all commits - [X] I have added unit tests for the new functionality - [X] I have run lint and test steps successfully - for `jaeger`: `make lint test` - for `jaeger-ui`: `yarn lint` and `yarn test` --------- Signed-off-by: Eshaan Aggarwal <[email protected]>

punithnayak added the bug label Jul 27, 2023

yurishkuro added cleanup and removed bug labels Jul 29, 2023

yurishkuro changed the title ~~Fix: eslint warnings~~ [chore]: Fix eslint warnings Jul 29, 2023

krishnasvp mentioned this issue Jul 31, 2023

[deps] Help with upgrading eslint-plugin-import #1613

Closed

Kavinjsir mentioned this issue Aug 9, 2023

Fix lint issues when bumping eslint-plugin-import #1652

Merged

3 tasks

yurishkuro added help wanted good first issue labels Aug 10, 2023

priyanshu-kun mentioned this issue Sep 15, 2023

FIx eslint warnings #1792

Closed

4 tasks

yurishkuro mentioned this issue Sep 15, 2023

[linter] Turn off no-empty-function rule #1796

Merged

priyanshu-kun mentioned this issue Sep 17, 2023

Fix linting warnings for no-unused-vars, no-var-requires #1800

Merged

4 tasks

priyanshu-kun pushed a commit to priyanshu-kun/jaeger-ui that referenced this issue Sep 17, 2023

Merge branch 'main' into priyanshu-kun/jaegertracing#1608

433175d

priyanshu-kun pushed a commit to priyanshu-kun/jaeger-ui that referenced this issue Sep 17, 2023

Merge branch 'main' into priyanshu-kun/jaegertracing#1608

5c45ede

Signed-off-by: priyanshu-kun <[email protected]>

yurishkuro closed this as completed in #1800 Sep 18, 2023

yurishkuro reopened this Oct 16, 2023

This was referenced Oct 24, 2023

Fix linting warnings for no-explicit-any, no-unused-vars, ban-types, ban-ts-comment #1908

Closed

Fix linting warnings for no-explicit-any, no-unused-vars, ban-types, ban-ts-comment #1909

Closed

Fix linting warnings for all no-unused-vars #1913

Merged

DerenToy mentioned this issue Oct 28, 2023

Fix linting warnings for Function, Boolean and String types #1916

Merged

4 tasks

EshaanAgg mentioned this issue Dec 24, 2023

fix: Fix some linting warnings #2064

Merged

4 tasks

EshaanAgg mentioned this issue Dec 24, 2023

lint: Fix some linter warnings #2069

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[chore]: Fix eslint warnings #1608

[chore]: Fix eslint warnings #1608

punithnayak commented Jul 27, 2023

punithnayak commented Jul 27, 2023

yurishkuro commented Jul 29, 2023

shuence commented Aug 10, 2023

yurishkuro commented Aug 10, 2023

[chore]: Fix eslint warnings #1608

[chore]: Fix eslint warnings #1608

Comments

punithnayak commented Jul 27, 2023

What happened?

Steps to reproduce

Expected behavior

Relevant log output

Screenshot

Additional context

Jaeger backend version

SDK

Pipeline

Stogage backend

Operating system

Deployment model

Deployment configs

punithnayak commented Jul 27, 2023

yurishkuro commented Jul 29, 2023

shuence commented Aug 10, 2023

yurishkuro commented Aug 10, 2023