Change 'make generate' to write only a single CRD #978
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
force-pushed
the
977-CRDs-as-single-items
branch
from
afde0ac to
7699cff
Compare
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
=======================================
Coverage 64.47% 64.47%
=======================================
Files 82 82
Lines 6536 6536
=======================================
Hits 4214 4214
Misses 2179 2179
Partials 143 143 Continue to review full report at Codecov.
|
pavolloffay
approved these changes
Mar 18, 2020
| # the controller-gen will generate a list of CRDs, but the operator-sdk tooling expects | ||
| # a single item | ||
| # the proper solutions are, in order: | ||
| # 1) find a controller-gen switch that makes it write only one CRD. Such a switch doesn't exist yet: https://git.io/JvX5D |
There was a problem hiding this comment.
It might be worth opening an issue in the controller-gen repo to let them know that this is causing problems.
pavolloffay
reviewed
Mar 18, 2020
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
|
@pavolloffay I updated the PR after you reviewed. Would you mind taking a look again, even if only at the latest commit? |
pavolloffay
approved these changes
Mar 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #977 by using
tailto chop off the first two lines of the CRD file.Signed-off-by: Juraci Paixão Kröhling [email protected]