Use non-cached CR on reconciliation #940
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpkrohling
force-pushed
the
Use-nocache-client-when-obtaining-CR
branch
from
ca4d437 to
aac0047
Compare
Codecov Report
@@ Coverage Diff @@
## master #940 +/- ##
=======================================
Coverage 64.45% 64.45%
=======================================
Files 82 82
Lines 6535 6535
=======================================
Hits 4212 4212
Misses 2179 2179
Partials 144 144
Continue to review full report at Codecov.
|
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
jpkrohling
force-pushed
the
Use-nocache-client-when-obtaining-CR
branch
from
aac0047 to
f534f5a
Compare
|
@rubenvp8510, @annanay25, would one of you please review this PR? |
annanay25
reviewed
Mar 10, 2020
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When receiving a reconciliation request, we try to obtain the CR that triggered the event from Kubernetes repository. When using the regular client, we might end up retrieving a cached version that isn't up to date, meaning that we might see errors like the following from time to time:
This error isn't a big problem, as it will trigger another reconciliation loop and things will eventually stabilize, but given that we might have a couple of reconciliation loops for the same object when it is first created, we want to bypass the cache and reduce the risk of facing this error.
Signed-off-by: Juraci Paixão Kröhling [email protected]