Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable agent injection to jaeger instances and when false value is used #903

Merged

Conversation

pavolloffay
Copy link
Member

@pavolloffay pavolloffay commented Feb 12, 2020

Resolves #900

Disables agent injection on:

Signed-off-by: Pavol Loffay [email protected]

pkg/inject/sidecar.go Outdated Show resolved Hide resolved
Signed-off-by: Pavol Loffay <[email protected]>
Copy link
Contributor

@jpkrohling jpkrohling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jpkrohling jpkrohling merged commit d2b690a into jaegertracing:master Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Jaeger agent can be injected into jaeger instance
2 participants