Always deploy client,data nodes with master node #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
objectiser
approved these changes
Aug 8, 2019
Signed-off-by: Pavol Loffay <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
=========================================
Coverage ? 91.27%
=========================================
Files ? 73
Lines ? 3655
Branches ? 0
=========================================
Hits ? 3336
Misses ? 227
Partials ? 92
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #586 +/- ##
=========================================
Coverage ? 91.27%
=========================================
Files ? 73
Lines ? 3655
Branches ? 0
=========================================
Hits ? 3336
Misses ? 227
Partials ? 92
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://issues.jboss.org/browse/TRACING-645
When number of ES nodes is > 3 we at the moment deploy 3 master nodes and N-3 client, data. The CLO operator deploys 3 master,client,data and N-3 client, data.
I think CLO approach is better because it does not allocate resources only for master nodes (Our spec exposes only one resouces for the whole ES spec, user cannot choose resources per node). It should be also better for us to align with CLO.
https://github.com/openshift/cluster-logging-operator/blob/release-4.1/pkg/k8shandler/logstore.go#L133
https://github.com/openshift/cluster-logging-operator/blob/master/pkg/k8shandler/logstore.go#L122
Signed-off-by: Pavol Loffay [email protected]