-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added htpasswd option to the OpenShift OAuth type #573
Added htpasswd option to the OpenShift OAuth type #573
Conversation
@jwendell, would you be able to confirm that this fixes the issue for you? I'm still running some manual tests on this, and we'd be ready to merge once you confirm it works, Travis approves and @objectiser reviews. This is the image that can be used for the test: |
Codecov Report
@@ Coverage Diff @@
## master #573 +/- ##
==========================================
+ Coverage 91.56% 91.57% +0.01%
==========================================
Files 73 73
Lines 3615 3620 +5
==========================================
+ Hits 3310 3315 +5
Misses 213 213
Partials 92 92
Continue to review full report at Codecov.
|
@objectiser, I tested this and when I could also not verify whether bearer tokens were issued at all, perhaps this is something that @rubenvp8510 could check. |
The newest image has just been published (version: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM -just need final approval from @jwendell to make sure it works for him.
I confirm it works fine, thanks! |
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
1b808b5
to
1fe0103
Compare
Alright, I just squashed the commits and updated the PR. Once Travis finishes, I'll merge it. |
In my tests I see that oauth-proxy store the bearer token encrypted in the cookie, but you need to pass the following flags:
And a better secret.. (16 bytes ) You can see how I did my tests on rubenvp8510/jaeger@2f1ea29 I'm actually working on change it to a simpler test, but that worked for me to learn how the propagation works with openshift oauth-proxy |
Closes #572 by adding a new field to the oauth proxy struct.
Signed-off-by: Juraci Paixão Kröhling [email protected]