Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure the ES operator's UUID is a valid DNS name #515

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Make sure the ES operator's UUID is a valid DNS name #515

merged 1 commit into from
Jul 9, 2019

Conversation

objectiser
Copy link
Contributor

@objectiser objectiser commented Jul 9, 2019

Fixes #510

Signed-off-by: Gary Brown [email protected]

@objectiser objectiser requested a review from jpkrohling July 9, 2019 09:00
@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #515 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #515   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files          65       65           
  Lines        3295     3295           
=======================================
  Hits         3030     3030           
  Misses        185      185           
  Partials       80       80
Impacted Files Coverage Δ
pkg/storage/elasticsearch.go 82.22% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 731baea...9e656a4. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jul 9, 2019

Codecov Report

Merging #515 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #515   +/-   ##
=======================================
  Coverage   91.95%   91.95%           
=======================================
  Files          65       65           
  Lines        3295     3295           
=======================================
  Hits         3030     3030           
  Misses        185      185           
  Partials       80       80
Impacted Files Coverage Δ
pkg/storage/elasticsearch.go 82.22% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 731baea...9e656a4. Read the comment docs.

@objectiser objectiser merged commit 1dfbda6 into jaegertracing:master Jul 9, 2019
@objectiser objectiser deleted the uuid2 branch July 9, 2019 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UUID value cannot use underscore
2 participants