Disable the property ttlSecondsAfterFinished #503
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
Signed-off-by: Juraci Paixão Kröhling <[email protected]>
objectiser
approved these changes
Jul 4, 2019
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
==========================================
- Coverage 91.95% 91.91% -0.04%
==========================================
Files 65 65
Lines 3292 3279 -13
==========================================
- Hits 3027 3014 -13
Misses 185 185
Partials 80 80
Continue to review full report at Codecov.
|
1 similar comment
Codecov Report
@@ Coverage Diff @@
## master #503 +/- ##
==========================================
- Coverage 91.95% 91.91% -0.04%
==========================================
Files 65 65
Lines 3292 3279 -13
==========================================
- Hits 3027 3014 -13
Misses 185 185
Partials 80 80
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #494 by making the property
ttlSecondsAfterFinishednoop. The property still exists in the CRD, as we can't remove due to backwards compatibility reasons, but we are effectively removing the actual feature until we can reliably check which feature gates are on.Signed-off-by: Juraci Paixão Kröhling [email protected]