Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstated the registration of ES types #366

Conversation

jpkrohling
Copy link
Contributor

Fixes #365 and #355

Signed-off-by: Juraci Paixão Kröhling [email protected]

Signed-off-by: Juraci Paixão Kröhling <[email protected]>
@jpkrohling jpkrohling requested a review from objectiser April 5, 2019 13:30
@jpkrohling
Copy link
Contributor Author

@jkandasa could you please test this change?

@codecov
Copy link

codecov bot commented Apr 5, 2019

Codecov Report

Merging #366 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #366   +/-   ##
=======================================
  Coverage   90.01%   90.01%           
=======================================
  Files          64       64           
  Lines        3076     3076           
=======================================
  Hits         2769     2769           
  Misses        207      207           
  Partials      100      100

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 390d5d4...5e53ecd. Read the comment docs.

@jpkrohling
Copy link
Contributor Author

I ran the e2e tests twice and it's working, confirming that it fixes #355.
$ make e2e-tests
Formatting code...
Building...
Sending build context to Docker daemon  214.3MB
Step 1/6 : FROM centos
 ---> 1e1148e4cc2c
Step 2/6 : RUN INSTALL_PKGS="       openssl       " &&     yum install -y $INSTALL_PKGS &&     rpm -V $INSTALL_PKGS &&     yum clean all &&     mkdir /tmp/_working_dir &&     chmod og+w /tmp/_working_dir
 ---> Using cache
 ---> 82728e7bfc7b
Step 3/6 : COPY scripts/* /scripts/
 ---> Using cache
 ---> e6e53eac569b
Step 4/6 : USER nobody
 ---> Using cache
 ---> 530be535f212
Step 5/6 : ADD build/_output/bin/jaeger-operator /usr/local/bin/jaeger-operator
 ---> 82d99df13d82
Step 6/6 : ENTRYPOINT ["/usr/local/bin/jaeger-operator"]
 ---> Running in d1b96e604054
Removing intermediate container d1b96e604054
 ---> 3c2f2b776359
Successfully built 3c2f2b776359
Successfully tagged jpkroehling/jaeger-operator:latest
Pushing image jpkroehling/jaeger-operator:latest...
Running Smoke end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	132.450s
Creating namespace default
Running Cassandra end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	141.310s
Running Elasticsearch end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	92.175s
customresourcedefinition.apiextensions.k8s.io/prometheusrules.monitoring.coreos.com configured
customresourcedefinition.apiextensions.k8s.io/servicemonitors.monitoring.coreos.com configured
serviceaccount/elasticsearch-operator unchanged
clusterrole.rbac.authorization.k8s.io/elasticsearch-operator configured
clusterrolebinding.rbac.authorization.k8s.io/elasticsearch-operator-rolebinding configured
customresourcedefinition.apiextensions.k8s.io/elasticsearches.logging.openshift.io configured
deployment.apps/elasticsearch-operator configured
Running Self provisioned Elasticsearch end-to-end tests...
ok  	github.com/jaegertracing/jaeger-operator/test/e2e	0.096s

@objectiser objectiser merged commit 0a41d7d into jaegertracing:master Apr 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants