Reinstated sidecar for query, plus small refactoring of sidecar

[jpkrohling]

This PR fixes #244 and applies a small refactoring to the sidecar injection. Special attention to the change to the annotation name, from "inject-jaeger-agent" to "sidecar.jaegertracing.io/inject" (already using a scheme from #201).

Signed-off-by: Juraci Paixão Kröhling [email protected]

[jpkrohling]

This change is 

[jpkrohling]

cc @jkandasa

[codecov]

Codecov Report

Merging #246 into master will decrease coverage by 0.36%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master     #246      +/-   ##
==========================================
- Coverage   89.69%   89.32%   -0.37%     
==========================================
  Files          62       62              
  Lines        2717     2745      +28     
==========================================
+ Hits         2437     2452      +15     
- Misses        181      189       +8     
- Partials       99      104       +5

Impacted Files	Coverage Δ
pkg/deployment/query.go	100% <100%> (ø)	⬆️
pkg/inject/sidecar.go	100% <100%> (ø)	⬆️
pkg/strategy/streaming.go	100% <100%> (ø)	⬆️
pkg/deployment/all-in-one.go	100% <100%> (ø)	⬆️
pkg/strategy/production.go	75.4% <100%> (ø)	⬆️
pkg/deployment/collector.go	100% <100%> (ø)	⬆️
pkg/controller/jaeger/elasticsearch.go	59.09% <0%> (-4.55%)	⬇️
pkg/controller/jaeger/jaeger_controller.go	32.92% <0%> (-0.41%)	⬇️
pkg/storage/elasticsearch.go	79.81% <0%> (-0.19%)	⬇️
pkg/storage/elasticsearch_secrets.go	100% <0%> (ø)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9302c08...b609551. Read the comment docs.

[objectiser]

LGTM - just wondering if a test is required on production.go and streaming.go just to confirm that the query has a sidecar?

[jpkrohling]

Test added