Fix contributing docs #1762
Merged
Fix contributing docs #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Earls <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1762 +/- ##
=======================================
Coverage 87.51% 87.51%
=======================================
Files 99 99
Lines 5937 5937
=======================================
Hits 5196 5196
Misses 567 567
Partials 174 174 Continue to review full report at Codecov.
|
iblancasa
previously approved these changes
Feb 21, 2022
pavolloffay
reviewed
Feb 21, 2022
CONTRIBUTING.md
Outdated
| Once minikube has finished starting, get the Operator running: | ||
|
|
||
| ``` | ||
| make cert-manager | ||
| IMG=docker.io/$USER/jaeger-operator:latest make generate bundle docker push deploy | ||
| export IMG_PREFIX=docker.io/<dockerusername> | ||
| export IMG=${IMG_PREFIX}/jaeger-operator:latest |
There was a problem hiding this comment.
any reason why the command is split? The original one is a single like copy paste and run which is easier to do.
|
Not really. I can put it on a single line if you prefer
…On Mon, Feb 21, 2022 at 11:57 AM Pavol Loffay ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In CONTRIBUTING.md
<#1762 (comment)>
:
> Once minikube has finished starting, get the Operator running:
```
make cert-manager
-IMG=docker.io/$USER/jaeger-operator:latest make generate bundle docker push deploy
+export IMG_PREFIX=docker.io/<dockerusername>
+export IMG=${IMG_PREFIX}/jaeger-operator:latest
any reason why the command is split? The original one is a single like
copy paste and run which is easier to do.
—
Reply to this email directly, view it on GitHub
<#1762 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHWJ2GOWVBI5TWLUQBAOXDU4ILAJANCNFSM5O54NLTA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Signed-off-by: Kevin Earls <[email protected]>
frzifus
approved these changes
Feb 21, 2022
Closed
pavolloffay
approved these changes
Feb 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Earls [email protected]
Which problem is this PR solving?
Short description of the changes