Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add preserve unknown fields annotation to FreeForm and Options fields #1435

Merged
merged 3 commits into from
May 26, 2021

Conversation

rubenvp8510
Copy link
Collaborator

Fixes #1314

Signed-off-by: Ruben Vargas [email protected]

@codecov
Copy link

codecov bot commented Apr 21, 2021

Codecov Report

Merging #1435 (0712cb9) into master (050e95a) will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1435      +/-   ##
==========================================
- Coverage   86.90%   86.88%   -0.02%     
==========================================
  Files          91       91              
  Lines        5078     5071       -7     
==========================================
- Hits         4413     4406       -7     
  Misses        510      510              
  Partials      155      155              
Impacted Files Coverage Δ
pkg/apis/jaegertracing/v1/jaeger_types.go 100.00% <ø> (ø)
pkg/apis/jaegertracing/v1/options.go 89.18% <0.00%> (-1.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 050e95a...0712cb9. Read the comment docs.

@rubenvp8510 rubenvp8510 requested a review from jpkrohling May 17, 2021 17:21
@jpkrohling jpkrohling enabled auto-merge (squash) May 18, 2021 13:57
@jpkrohling jpkrohling merged commit 139cdd2 into jaegertracing:master May 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some fields need pruning control for CRD
2 participants