Simplify OTEL related environment variables #1255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kevin Earls <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1255 +/- ##
=======================================
Coverage 87.36% 87.36%
=======================================
Files 90 90
Lines 4907 4907
=======================================
Hits 4287 4287
Misses 457 457
Partials 163 163 Continue to review full report at Codecov.
|
Signed-off-by: Kevin Earls <[email protected]>
jpkrohling
reviewed
Oct 14, 2020
Signed-off-by: Kevin Earls <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Earls [email protected]
This PR reduces the number of OTEL related EVs used by tests to two, and separates their functions. If SPECIFY_OTEL_IMAGES is true the tests will explicitly add otel image names to CRs. If SPECIFY_OTEL_CONFIG is true we will remove config values that are not used by the OTEL collector or ingester.