Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add consolelink permissions to cluster role #1177

Merged
merged 1 commit into from
Sep 4, 2020

Conversation

rubenvp8510
Copy link
Collaborator

Signed-off-by: Ruben Vargas [email protected]

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #1177 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1177   +/-   ##
=======================================
  Coverage   88.30%   88.30%           
=======================================
  Files          89       89           
  Lines        5506     5506           
=======================================
  Hits         4862     4862           
  Misses        474      474           
  Partials      170      170           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f394fea...84998f1. Read the comment docs.

@jpkrohling
Copy link
Contributor

Could you run the "generate CSV" command and see if the next CSV will include this change? The release script has a step where it generates the CSV for the new version, you can use that as reference.

@rubenvp8510
Copy link
Collaborator Author

I ran this command:

operator-sdk generate csv --csv-channel=stable --csv-version="1.19.1" --from-version="1.19.0"

And it seems like the change is included on the manifest.

@jpkrohling
Copy link
Contributor

@kevinearls, @rubenvp8510, there's a failing test. Is it a known issue?

@jpkrohling
Copy link
Contributor

    TestDaemonSetSuite/TestDaemonSet: daemonset_test.go:151: 
        	Error Trace:	daemonset_test.go:151
        	Error:      	Received unexpected error:
        	            	timed out waiting for the condition
        	Test:       	TestDaemonSetSuite/TestDaemonSet
        	Messages:   	Failed waiting for expected content

@rubenvp8510, could you rebase the PR? This test failure has been fixed in the latest master.

@rubenvp8510
Copy link
Collaborator Author

Rebased, is green now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants