-
Notifications
You must be signed in to change notification settings - Fork 345
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Apply the securityContext to the cassandraCreateSchema job #1167
Conversation
Signed-off-by: chgl <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1167 +/- ##
=======================================
Coverage 88.29% 88.29%
=======================================
Files 89 89
Lines 5501 5502 +1
=======================================
+ Hits 4857 4858 +1
Misses 474 474
Partials 170 170
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fix looks good, would you be able to add a test as well, to ensure we don't have a regression in the future?
Signed-off-by: chgl <[email protected]>
@jpkrohling does this look ok? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Will merge on green.
Thank you for your contribution! |
Thank you and the team for making the contribution experience so smooth :). Hope this doesn't sound impatient: is there an ETA for the next release? |
You are actually lucky: we are planning a release this week. |
Great to hear, thank you! |
Resolves #1166