Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set correct branch for ES 4.4 #1081

Merged
merged 2 commits into from
Jun 8, 2020

Conversation

pavolloffay
Copy link
Member

Set the correct branch for self-provisioned ES. Currently we are using 4.4 by directly setting the image version. The branch is used for k8s manifest files, hence it's better to be consistent.

Signed-off-by: Pavol Loffay [email protected]

Signed-off-by: Pavol Loffay <[email protected]>
@pavolloffay pavolloffay requested a review from kevinearls June 8, 2020 10:58
@codecov
Copy link

codecov bot commented Jun 8, 2020

Codecov Report

Merging #1081 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1081   +/-   ##
=======================================
  Coverage   87.81%   87.81%           
=======================================
  Files          85       85           
  Lines        5172     5172           
=======================================
  Hits         4542     4542           
  Misses        466      466           
  Partials      164      164           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e48d7d3...ae98455. Read the comment docs.

Signed-off-by: Pavol Loffay <[email protected]>
Copy link
Contributor

@kevinearls kevinearls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pavolloffay pavolloffay merged commit c920e75 into jaegertracing:master Jun 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants