Add OTEL config to all-in-one #1080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Pavol Loffay <[email protected]>
Signed-off-by: Pavol Loffay <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1080 +/- ##
===========================================
+ Coverage 64.69% 87.81% +23.12%
===========================================
Files 86 85 -1
Lines 7013 5172 -1841
===========================================
+ Hits 4537 4542 +5
+ Misses 2313 466 -1847
- Partials 163 164 +1
Continue to review full report at Codecov.
|
pavolloffay
commented
Jun 3, 2020
| @@ -60,21 +62,26 @@ func (a *AllInOne) Get() *appsv1.Deployment { | |||
| sampling.Update(a.jaeger, commonSpec, &options) | |||
| tls.Update(a.jaeger, commonSpec, &options) | |||
|
|
|||
| if len(util.FindItem("--reporter.type=", options)) == 0 { | |||
| options = append(options, "--reporter.type=grpc") | |||
There was a problem hiding this comment.
not needed. there is only grpc reporter that is used by default
Signed-off-by: Pavol Loffay <[email protected]>
objectiser
approved these changes
Jun 4, 2020
|
Looks like coverage affected by error paths - possible add some invalid otel config in a separate test? |
Signed-off-by: Pavol Loffay <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Pavol Loffay [email protected]
Example CR