Upgrade Prometheus client to 1.1 and go-kit to 0.9 #78
Conversation
Signed-off-by: Yuri Shkuro <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #78 +/- ##
=====================================
Coverage 100% 100%
=====================================
Files 26 26
Lines 890 890
=====================================
Hits 890 890Continue to review full report at Codecov.
|
Signed-off-by: Yuri Shkuro <[email protected]>
glide.yaml
Outdated
| subpackages: | ||
| - metrics/influx | ||
| - package: github.com/uber-go/tally | ||
| version: '>= 2.1.0, < 4' | ||
| - package: github.com/prometheus/client_golang | ||
| version: v0.8.0 | ||
| version: v1.1.0 |
There was a problem hiding this comment.
I think for glide, you still want a version range rather than an exact version.
^1 should suffice for client_golang and ~0.9.0 for go-kit.
(If I remember correctly, "X.Y.Z" does the right thing in dep so ~ or ^ aren't needed in the Gopkg.toml.)
| "github.com/stretchr/testify/assert" | ||
|
|
||
| "github.com/uber/jaeger-lib/metrics" | ||
| "github.com/uber/jaeger-lib/metrics/go-kit" | ||
| ) | ||
|
|
||
| // "github.com/uber/jaeger-lib/vendor/github.com/influxdata/influxdb/client/v2".BatchPointsConfig | ||
| // "github.com/uber/jaeger-lib/vendor/github.com/influxdata/influxdb1-client/v2".BatchPointsConfig |
Signed-off-by: Yuri Shkuro <[email protected]>
There was a problem hiding this comment.
I just realized that you'll need to release this at the same time as jaeger-client, otherwise glide will fail with an unsatisfiable constraint: ^1 and == 0.8 aren't compatible.
If you'd like to guard against that, consider changing client_golang to >= 0.8, < 2 as jaeger-lib is compatible with 0.8, 0.9, and 1.x.
Signed-off-by: Yuri Shkuro <[email protected]>
|
@abhinav I don't see an issue with releasing client and lib simultaneously. |
Resolves #77