This repository has been archived by the owner on May 18, 2020. It is now read-only.
Explicit env var for CSQLSH_HOST in k8s resource #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making CSQLSH_HOST explicit makes it easier to understand how the schema job discovers the cassandra cluster. It also provide a helpful clue for users that might be deploying cassandra under a name other than "cassandra", which is the default value hard-coded into the schema job's docker image.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making CSQLSH_HOST explicit makes it easier to understand how the schema job discovers the cassandra cluster. It also provide a helpful clue for users that might be deploying cassandra under a name other than "cassandra", which is the default value hard-coded into the schema job's docker image.
Which problem is this PR solving?
Short description of the changes