This repository has been archived by the owner on May 23, 2024. It is now read-only.
Fix baggage/debug header tests to not defer in loops #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes the unit tests for baggage/debug headers so that the "defer closer.Close()" statement is not executed in a for loop, but rather within a nested test function execution. Signed-off-by: Zvi Cahana <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
==========================================
+ Coverage 86.8% 86.84% +0.03%
==========================================
Files 54 54
Lines 2956 2956
==========================================
+ Hits 2566 2567 +1
+ Misses 275 273 -2
- Partials 115 116 +1
Continue to review full report at Codecov.
|
black-adder
approved these changes
May 24, 2018
|
thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
This PR fixes the unit tests for baggage/debug headers so that the
defer closer.Close()statement is not executed in a for loop, but rather within a nested test function execution.Addressing @yurishkuro's review comment from #313.
Signed-off-by: Zvi Cahana [email protected]