This repository has been archived by the owner on May 23, 2024. It is now read-only.
Add RPC metrics emitter as Observer/SpanObserver #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 25, 2017
yurishkuro
force-pushed
the
metrics-observer
branch
from
024fac3 to
f1f36e8
Compare
yurishkuro
changed the title
yurishkuro
force-pushed
the
metrics-observer
branch
from
3472e44 to
2ab6f8e
Compare
yurishkuro
changed the title
yurishkuro
changed the title
added 2 commits
March 2, 2017 23:09
oibe
reviewed
Mar 3, 2017
rpcmetrics/endpoints.go
Outdated
| norm = n.normalizer.Normalize(name) | ||
| n.mux.Lock() | ||
| defer n.mux.Unlock() | ||
| if len(n.names) >= n.maxSize { |
There was a problem hiding this comment.
Maybe move this check to before we call n.normalizer.Normalize. Why call "Normalize" if we might be over max cache size and we will just return ""?
There was a problem hiding this comment.
I did it so that the call to Normalize is done outside of the exclusive lock. But you're right that if the service ever reaches the upper limit of the cache it will be paying normalization cost for every call.
oibe
reviewed
Mar 3, 2017
rpcmetrics/observer.go
Outdated
| metricsByEndpoint *MetricsByEndpoint | ||
| } | ||
|
|
||
| // NewObserver creates a new observer that can emit RPC metricso. |
black-adder
approved these changes
Mar 3, 2017
rpcmetrics/observer.go
Outdated
| err bool | ||
| } | ||
|
|
||
| // NewSpanObserver creates a new SpanObserver that can emit RPC metricso. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.